Ticket #360 (new defect)

Opened 5 months ago

Last modified 4 weeks ago

Not showing focus frame and no blinking cursor in input text area

Reported by: alex Assigned to: mbensi
Priority: major Milestone: Pukarua
Component: Bug Fix Version: 1.0
Keywords: Cc: jchaffraix@pleyo.com
Number of hours worked: % Complete: 00
Number of hours remaining:

Description

It does not show focus frame and there is no blinking cursor in the input text area using Pukapuka 1.0, whereas they work well under Galeking. Tested with SDL port.

Change History

(follow-up: ↓ 3 ) 10/14/09 06:04:42 changed by alex

  • milestone set to Pukarua.

I modify WebCore/page/FocusController.cpp as

78: void FocusController::setFocusedFrame(PassRefPtr<Frame> frame)
79: {
       ...
94:    - if(newFrame && newFrame->view() && isFocused()) {
94:    + if(newFrame && newFrame->view()) {
       ...
98: }

Then it works well, though it seems just a workaround. I believe that there was some reason to add "isFocused()" there. Can anyone help confirm?

10/14/09 13:45:01 changed by Fab1

I might be wrong, but i remember i had a similar issue in my port a few months ago, which i fixed. IIRC, it has more to do with unimplemented methods. Something like WebChromeClient::canTakeFocus/WebChromeClient::takeFocus() and WebView::active() that needed to be implemented properly.

(in reply to: ↑ 1 ) 12/08/09 15:56:38 changed by jchaffraix

  • cc set to jchaffraix@pleyo.com.

78: void FocusController::setFocusedFrame(PassRefPtr<Frame> frame) 79: { ... 94: - if(newFrame && newFrame->view() && isFocused()) { 94: + if(newFrame && newFrame->view()) { ... 98: } }}} Then it works well, though it seems just a workaround. I believe that there was some reason to add "isFocused()" there. Can anyone help confirm?

Looking at the WebKit commit that introduce it. I think it is a way to avoid dispatching focus events on background tabs (http://trac.webkit.org/changeset/45440).

Following Fab1 advices, I have implemented some ChromeClient's methods (I am not sure it was necessary but I gave that a try anyway). Could you confirm whether this fixed this issue?

Thanks for the report!

02/23/10 14:49:11 changed by sim

decoration Changed 1 year ago by admin

bathtub Changed 1 year ago by admin

solar system Changed 1 year ago by admin

stair parts Changed 1 year ago by admin

solar supply Changed 1 year ago by admin