Ticket #358 (new task)

Opened 6 months ago

Last modified 4 weeks ago

Some patches to CMake to recompile AmigaOS version again..

Reported by: afxgroup Assigned to: mbensi
Priority: major Milestone: Pukarua
Component: Bug Fix Version: 1.0
Keywords: AMIGAOS4 Cc:
Number of hours worked: % Complete: 00
Number of hours remaining:

Description

Attached some patches to various CMakeLists.txt to compile AmigaOS4 version of OWB again.

Attachments

OS4Patches.tgz (1.2 kB) - added by afxgroup on 10/01/09 23:12:15.
OS4 Patches
OS4_2.tgz (1.5 kB) - added by afxgroup on 10/01/09 23:47:24.
Other small patches

Change History

10/01/09 23:12:15 changed by afxgroup

  • attachment OS4Patches.tgz added.

OS4 Patches

10/01/09 23:47:24 changed by afxgroup

  • attachment OS4_2.tgz added.

Other small patches

(follow-up: ↓ 2 ) 10/06/09 10:14:11 changed by odole

Review of the patch:

  • Would it be possible to use a tool like pkg-config instead of hardcoded path to setup fonts variables (cmake/CheckPlatformFonts.cmake) ?
  • Could you use GRAPHICS_INCLUDE_DIRS instead of appending include directory to CMAKE_CXX_FLAGS in cmake/CheckPlatformGraphics.cmake
  • if(USE_GRAPHICS STREQUAL "AMIGAOS4") or things like that are sorted by alphabetical order so for AMIGAOS4 you have to put it in first position ;)
  • I have reverted changes about BAL/Graphics/WebCore/WK/BCDragDataWK.h and BAL/Graphics/WebCore/WK/BCDragImageWK.h. The types you redefine can be redefined in Base/AmigaOS4/BALTypeAmigaOS4.h.
  • When you modify a file imported from WebCore or JavaScriptCore, typically WK or WTF files, think to add if necessary in BAL/Scripts/data/WebKitFiles.txt else your modifications will be reverted by the merge with WebKit trunk.

Nonetheless your patch has been committed at revision [1082]. Just have look at the changeset to see the modification I made.

(in reply to: ↑ 1 ) 10/07/09 02:00:11 changed by jstrohmayer

Replying to odole:

Review of the patch:
* Would it be possible to use a tool like pkg-config instead of hardcoded path to setup fonts variables (cmake/CheckPlatformFonts.cmake) ?

On AmigaOS itself pgk-config is working, he might have to fix the paths when using a cross-compiler, though.
But the added includes and libraries don't make any sense anyway since the AmigaOS port of OWB doesn't use libfontconfig nor libfreetype, it's using a native AmigaOS font implementation. It's possible to use fontconfig/freetype in the AmigaOS port instead, but for that you just have to select FREETYPE as font engine instead of AMIGAOS4.

02/23/10 14:51:27 changed by sim

decoration Changed 1 year ago by admin

bathtub Changed 1 year ago by admin

solar system Changed 1 year ago by admin

stair parts Changed 1 year ago by admin

solar supply Changed 1 year ago by admin