Ticket #279 (closed enhancement: fixed)

Opened 4 months ago

Last modified 3 months ago

Display a generic image when plugin is not available

Reported by: odole Assigned to: jcverdie
Priority: minor Milestone: Galekid
Component: Browser Improvement Version: 1.0
Keywords: plugin Cc:
Number of hours worked: 13 % Complete: 100
Number of hours remaining:

Description

When we browse a site that requires a missing plugin, we should display a default image instead of a black window to warn the user that the content cannot be displayed due to the lack of the required plugin.

Attachments

missing-plugin.png (50.4 kB) - added by odole on 08/01/08 15:47:17.
typical image to display for a missing plugin
owb-missing-plugin.jpg (90.8 kB) - added by odole on 08/01/08 15:57:57.
screenshot of what should be displayed when a plugin is not found
plugin-proof-of-concept.patch (10.4 kB) - added by odole on 08/01/08 16:00:28.
patch which is the proof of concept
plugin-proof-of-concept-r440.patch (9.9 kB) - added by odole on 08/18/08 12:11:39.
patch update for revision 440 (compilation fix)
missing-plugin-sdl-r457.patch (136.3 kB) - added by odole on 08/26/08 18:58:58.
clean fix for SDL version

Change History

08/01/08 15:47:17 changed by odole

  • attachment missing-plugin.png added.

typical image to display for a missing plugin

08/01/08 15:57:57 changed by odole

  • attachment owb-missing-plugin.jpg added.

screenshot of what should be displayed when a plugin is not found

08/01/08 16:00:28 changed by odole

  • attachment plugin-proof-of-concept.patch added.

patch which is the proof of concept

08/01/08 16:03:55 changed by odole

The plugin-proof-of-concept.patch is only a proof of concept for SDL version.
This patch is quite ugly as some free/close are not done :S
But it gives you the main idea on how to implement this feature.
The proper way would be to implement things like loadResourceIntoArray or SharedBuffer::createWithContentsOfFile and use them to create image to display.

08/18/08 12:11:39 changed by odole

  • attachment plugin-proof-of-concept-r440.patch added.

patch update for revision 440 (compilation fix)

08/26/08 18:50:58 changed by odole

  • hours_worked changed from 5 to 13.
  • percent set to 90.

patch is not OK !!!
it breaks build with SDL and NPAPI to OFF: 

/home/developer/owb-src/Doduo_current/build_sdl_min/lib/libwebcore-owb.so: undefined reference to `WebCore::PluginView::invalidateRegion(void*)'

I will update it.

08/26/08 18:58:58 changed by odole

  • attachment missing-plugin-sdl-r457.patch added.

clean fix for SDL version

08/26/08 18:59:29 changed by odole

patch updated, should be OK now.

08/26/08 19:27:47 changed by mbensi

  • percent changed from 90 to 100.

reviewed and commited revision 459

08/26/08 19:27:58 changed by mbensi

  • status changed from new to closed.
  • resolution set to fixed.