Ticket #278 (closed task: fixed)

Opened 4 months ago

Last modified 4 months ago

AmigaOS4 fonts implementation

Reported by: jstrohmayer Assigned to: odole
Priority: major Milestone: Galekid
Component: Browser Improvement Version: 1.0
Keywords: Amiga Cc:
Number of hours worked: % Complete: 100
Number of hours remaining:

Description

AmigaOS 4.x fonts implementation and added zoom in/out (F3/F4) support.

Attachments

AmigaOS4-fonts.patch (60.4 kB) - added by jstrohmayer on 07/31/08 18:10:39.

Change History

07/31/08 18:10:39 changed by jstrohmayer

  • attachment AmigaOS4-fonts.patch added.

07/31/08 19:27:55 changed by odole

  • owner changed from jcverdie to odole.
  • status changed from new to assigned.

I will review that patch ASAP and give you feedback.

07/31/08 19:52:51 changed by odole

  • status changed from assigned to closed.
  • resolution set to fixed.
  • percent set to 100.

The patch is ok and is committed at revision [426].
About coding style everything was perfect except some variable names (camelCase would be better) and also some functions name in the part which tracks font leaks. But as it is a pure AmigaOS implementation, there is no problem for me.
Note: I am really impressed by your mechanism to track font leaks. I will try to warn you if we find a pure WebCore solution, to remove our remaining font leaks, which would deprecate your system.