Changeset 412

Show
Ignore:
Timestamp:
07/23/08 11:06:58 (4 months ago)
Author:
odole
Message:

2008-07-23 Olivier DOLE <odole@pleyo.com>

Reviewed by Mario Bensi.
Fix leak and weak code in WebView.

  • OrigynWebBrowser/Api/WebView.cpp:
    (buffer):
    (WebView::parseConfigFile):
Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/WebKit/ChangeLogOWB

    r401 r412  
     12008-07-23  Olivier DOLE  <odole@pleyo.com> 
     2 
     3        Reviewed by Mario Bensi. 
     4        Fix leak and weak code in WebView. 
     5 
     6        * OrigynWebBrowser/Api/WebView.cpp: 
     7        (buffer): 
     8        (WebView::parseConfigFile): 
     9 
    1102008-07-18  Olivier DOLE  <odole@pleyo.com> 
    211 

  • trunk/WebKit/OrigynWebBrowser/Api/WebView.cpp

    r397 r412  
    14371437    if (!configFile) 
    14381438        return String(); 
    1439     if (configFile->open('r') == -1) 
     1439    if (configFile->open('r') == -1) { 
     1440        delete configFile; 
    14401441        return String(); 
     1442    } 
    14411443    String buffer(configFile->read(configFile->getSize())); 
    14421444    configFile->close(); 
    …… 
    14481450void WebView::parseConfigFile(String url) 
    14491451{ 
    1450     int width, height = 0; 
     1452    int width = 0, height = 0; 
    14511453    String fileBuffer = buffer(url); 
    14521454    while (!fileBuffer.isEmpty()) {