Changeset 408

Show
Ignore:
Timestamp:
07/22/08 11:28:32 (5 months ago)
Author:
mbensi
Message:

2008-07-22 Mario Bensi <mbensi@pleyo.com>

Reviewed by Olivier DOLE.
move all method inline

  • OWBAL/Concretizations/Internationalization/Generic/BCUnicodeGeneric.cpp: Removed.
  • OWBAL/Concretizations/Internationalization/Generic/BCUnicodeGeneric.h:
    (WTF::Unicode::toLower):
    (WTF::Unicode::foldCase):
    (WTF::Unicode::toUpper):
    (WTF::Unicode::toTitleCase):
    (WTF::Unicode::isArabicChar):
    (WTF::Unicode::category):
    (WTF::Unicode::isFormatChar):
    (WTF::Unicode::isSeparatorSpace):
    (WTF::Unicode::isPrintableChar):
    (WTF::Unicode::isDigit):
    (WTF::Unicode::isPunct):
    (WTF::Unicode::mirroredChar):
    (WTF::Unicode::direction):
    (WTF::Unicode::isLower):
    (WTF::Unicode::digitValue):
    (WTF::Unicode::combiningClass):
    (WTF::Unicode::decompositionType):
    (WTF::Unicode::umemcasecmp):
Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/BAL/ChangeLogOWB

    r407 r408  
     12008-07-22  Mario Bensi  <mbensi@pleyo.com> 
     2 
     3        Reviewed by Olivier DOLE. 
     4        move all method inline 
     5 
     6        * OWBAL/Concretizations/Internationalization/Generic/BCUnicodeGeneric.cpp: Removed. 
     7        * OWBAL/Concretizations/Internationalization/Generic/BCUnicodeGeneric.h: 
     8        (WTF::Unicode::toLower): 
     9        (WTF::Unicode::foldCase): 
     10        (WTF::Unicode::toUpper): 
     11        (WTF::Unicode::toTitleCase): 
     12        (WTF::Unicode::isArabicChar): 
     13        (WTF::Unicode::category): 
     14        (WTF::Unicode::isFormatChar): 
     15        (WTF::Unicode::isSeparatorSpace): 
     16        (WTF::Unicode::isPrintableChar): 
     17        (WTF::Unicode::isDigit): 
     18        (WTF::Unicode::isPunct): 
     19        (WTF::Unicode::mirroredChar): 
     20        (WTF::Unicode::direction): 
     21        (WTF::Unicode::isLower): 
     22        (WTF::Unicode::digitValue): 
     23        (WTF::Unicode::combiningClass): 
     24        (WTF::Unicode::decompositionType): 
     25        (WTF::Unicode::umemcasecmp): 
     26 
    1272008-07-21  Olivier DOLE  <odole@pleyo.com> 
    228 
  • trunk/BAL/OWBAL/Concretizations/Internationalization/Generic/BCUnicodeGeneric.h

    r243 r408  
    126126    }; 
    127127 
    128     UChar32 toLower(UChar32 c); 
    129     int toLower(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error); 
    130     UChar32 toUpper(UChar32 c); 
    131     int toUpper(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error); 
    132     UChar32 foldCase(UChar32 c); 
    133     int foldCase(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error); 
    134     UChar32 toTitleCase(UChar32 c); 
    135     bool isFormatChar(UChar32 c); 
    136     bool isSeparatorSpace(UChar32 c); 
    137     bool isPrintableChar(UChar32 c); 
    138     bool isDigit(UChar32 c); 
    139     bool isPunct(UChar32 c); 
    140     UChar32 mirroredChar(UChar32 c); 
    141     CharCategory category(UChar32 c); 
    142     Direction direction(UChar32 c); 
    143     bool isLower(UChar32 c); 
    144     bool isUpper(UChar32 c); 
    145     int digitValue(UChar32 c); 
    146     uint8_t combiningClass(UChar32 c); 
    147     DecompositionType decompositionType(UChar32 c); 
    148     int umemcasecmp(const UChar* a, const UChar* b, int len); 
    149     bool isArabicChar(UChar32 c); 
    150     /*inline UChar32 toLower(UChar32 c) 
     128    inline UChar32 toLower(UChar32 c) 
    151129    { 
    152130        if ((c >= 0x41 && c <= 0x5A) || (c >= 0xC0 && c <= 0xDE)) 
     
    171149        for (int i = 0; i < srcLength; ++i) 
    172150            result[i] = foldCase(src[i]); 
     151 
    173152        return srcLength; 
    174153    } 
     
    197176    inline int toUpper(UChar* result, int resultLength, const UChar* src, int srcLength, bool* error) 
    198177    { 
     178        //printf("toUpper\n"); 
    199179        *error = false; 
    200180        if (resultLength < srcLength) { 
     
    209189    inline UChar32 toTitleCase(UChar32 c) 
    210190    { 
    211         return c; 
     191        //printf("toTitleCase\n"); 
     192        return toUpper(c); 
    212193    } 
    213194 
    214195    inline bool isArabicChar(UChar32 c) 
    215196    { 
    216         BalNotImplemented(); 
     197        //printf("isArabicChar\n"); 
     198        //BalNotImplemented(); 
    217199        return false; 
    218200    } 
     
    220202    inline CharCategory category(UChar32 c) 
    221203    { 
     204        //printf("category\n"); 
    222205        if (c == 0x0D) 
    223206            return WTF::Unicode::Separator_Line; 
     
    253236    inline bool isFormatChar(UChar32 c) 
    254237    { 
     238        //printf("isFormatChar\n"); 
    255239        return (c & 0xffff0000) == 0 && category(c) == WTF::Unicode::Other_Format; 
    256240    } 
     
    258242    inline bool isSeparatorSpace(UChar32 c) 
    259243    { 
     244        //printf("isSeparatorSpace\n"); 
    260245        return (c & 0xffff0000) == 0 && category(c) == WTF::Unicode::Separator_Space; 
    261246    } 
     
    263248    inline bool isPrintableChar(UChar32 c) 
    264249    { 
    265         BalNotImplemented(); 
     250        //printf("isPrintableChar c=%x\n",c); 
     251        //BalNotImplemented(); 
    266252        return false; 
    267253    } 
     
    269255    inline bool isDigit(UChar32 c) 
    270256    { 
     257        //printf("isDigit\n"); 
    271258        return (c & 0xffff0000) == 0 && category(c) == WTF::Unicode::Number_DecimalDigit; 
    272259    } 
     
    274261    inline bool isPunct(UChar32 c) 
    275262    { 
     263        //printf("isPunct\n"); 
    276264        return (c & 0xffff0000) == 0 && (category(c) == WTF::Unicode::Punctuation_Dash 
    277265                                    || category(c) == WTF::Unicode::Punctuation_Open 
     
    285273    inline UChar32 mirroredChar(UChar32 c) 
    286274    { 
    287         BalNotImplemented(); 
     275        //printf("mirroredChar\n"); 
     276        //BalNotImplemented(); 
    288277        return c; 
    289278    } 
     
    291280    inline Direction direction(UChar32 c) 
    292281    { 
    293         BalNotImplemented(); 
     282        //printf("direction\n"); 
     283        //BalNotImplemented(); 
    294284        return WTF::Unicode::LeftToRight; 
    295285    } 
     
    297287    inline bool isLower(UChar32 c) 
    298288    { 
     289        //printf("isLower\n"); 
    299290        return (c & 0xffff0000) == 0 && category(c) == WTF::Unicode::Letter_Lowercase; 
    300291    } 
     
    302293    inline int digitValue(UChar32 c) 
    303294    { 
     295        //printf("digitValue\n"); 
    304296        return c-0x30; 
    305297    } 
     
    307299    inline unsigned char combiningClass(UChar32 c) 
    308300    { 
    309         BalNotImplemented(); 
     301        //printf("combiningClass\n"); 
     302        //BalNotImplemented(); 
    310303        return c; 
    311304    } 
     
    313306    inline DecompositionType decompositionType(UChar32 c) 
    314307    { 
    315         BalNotImplemented(); 
     308        //printf("decompositionType\n"); 
     309        //BalNotImplemented(); 
    316310        return WTF::Unicode::DecompositionNone; 
    317311    } 
     
    319313    inline int umemcasecmp(const UChar* a, const UChar* b, int len) 
    320314    { 
     315        //printf("umemcasecmp len =%d\n", len); 
    321316        for (int i = 0; i < len; ++i) { 
    322317            UChar32 c1 = toLower(a[i]); 
    323318            UChar32 c2 = toLower(b[i]); 
    324319            if (c1 != c2) 
    325                 return c1 < c2
     320                return -1
    326321        } 
    327322        return 0; 
    328     }*/ 
     323    } 
     324 
    329325 
    330326  }