Ticket #106: BCResourceCurl-leak.6.patch

/dev/null

@@ +1 @@
+2007-12-11  Julien Chaffraix  <julien.chaffraix@gmail.com>
+
+        Reviewed by NOBODY (OOPS!).
+
+        * Implementations/Network/CURL/BCResourceHandleCURL.cpp:
+        (BC::BCResourceHandleCURL::~BCResourceHandleCURL):
+        (BC::BCResourceHandleCURL::setupPUT):
+
+        Correct a memory leak in ~BCResourceHandleCURL (m_url is allocated through strdup and was not freed)
+        Correct one typo and several coding style issues

a/branches/Blastoise/BAL/Implementations/Network/CURL/BCResourceHandleCURL.cpp

@@ -119 +119 @@
-
-BCResourceHandleCURL::~BCResourceHandleCURL()
-{
-
+ 
-        BAL::getBIObserverService()->removeObserver(String("SendCookies"), this);
-        BAL::getBIResourceHandleManager()->cancel(this); // ensure that job is removed from manager's job list
-    }
@@ -128 +128 @@
-    if (m_customHeader)
-        curl_slist_free_all(m_customHeader);
-
-
-       
+ 
+    
-            curl_easy_cleanup(m_handle);
-    m_client = 0;
+
+    if (m_url)
+        free(m_url);
-}
-
-void BCResourceHandleCURL::setURL(const char* url)
@@ -150 +153 @@
-    curl_easy_setopt(m_handle, CURLOPT_UPLOAD, true) ;
-    struct curl_slist *slist=NULL;
-    //FIXME: hmmm disable Expect: 100-continue
-ro
+or
-    slist = curl_slist_append(slist, "Transfer-Encoding: chunked");
-    curl_easy_setopt(m_handle, CURLOPT_HTTPHEADER, slist);
-    m_customPostHeader = slist;